copy_version_files.ps1 improve comparison#124341
Merged
pavelsavara merged 1 commit intodotnet:mainfrom Feb 12, 2026
Merged
Conversation
github-actions
Bot
added
the
needs-area-label
Contributor
There was a problem hiding this comment.
Pull request overview
Improves incremental build stability on Windows by changing how _version.c placeholder content is compared before overwriting the generated copy under artifacts/obj.
Changes:
- Replace the
-necomparison withCompare-Objectwhen deciding whether to overwriteartifacts/obj/_version.c. - Add an explanatory comment describing the overwrite condition.
pavelsavara
removed
the
needs-area-label
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/runtime-infrastructure |
jkoritzinsky
approved these changes
Feb 12, 2026
iremyux
pushed a commit
to iremyux/dotnet-runtime
that referenced
this pull request
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it was too sensitive to white space on windows - breaks incremental build on windows